Comments on: Outputing a MySQL result in a HTML table

By: Jexus

Jexus — Thu, 30 Mar 2006 00:21:59 +0000

Just wondering, you do an is_numeric check, after which you cast the value to an integer. This is of course, wrong, as it could also be like 2.3, after which the value would be 0? Correct me if i’m wrong;)

[Editor's Note: Fixed, thanks!]

By: Firman

Firman — Mon, 03 Oct 2005 13:37:54 +0000

Just a bit addition at the first line of function, to avoid the errors.

if (!is_resource($result) || get_resource_type != ‘mysql result’) {
return false;
}

[Editor's Note: Thanks firman ]

By: Tosa

Tosa — Sun, 14 Nov 2004 18:44:01 +0000

Thank you! This saved my day!

By: Jumbobrian

Jumbobrian — Sat, 06 Nov 2004 18:26:59 +0000

i love this script, and have modified to to my needs successfully. just one idea… have you considered making the table colored? if you alternated between two colors every row, it could make it easier to see.

By: Anonymous

Anonymous — Fri, 05 Nov 2004 00:37:01 +0000

Thanks for this, Good work.

By: Roshambo

Roshambo — Fri, 05 Nov 2004 00:37:01 +0000

brilliant!

By: Cili

Cili — Fri, 05 Nov 2004 00:37:01 +0000

bravos

By: Jan

Jan — Fri, 05 Nov 2004 00:37:01 +0000

I think this is a good function, with ONE remark: Putting the mysql_num_rows($result); function in the for-loop slows it down. It’s better to call this function before the loop.

[Editor's Note: Ooops, fixed]

By: Gnif

Gnif — Fri, 05 Nov 2004 00:37:01 +0000

bravo, this is a very nice implementation, but how will is handle a null field, can it be changed so that you can tell it what to use for a null? I could just do it myself, but then others wouldn’t be able to benifit.

Eg. 2nd param:
mysql_draw_table($result, ‘[NULL]‘);
mysql_draw_table($result, ‘ ’ );

[Editor's Note: All done]

By: Neott

Neott — Fri, 05 Nov 2004 00:37:01 +0000

found tis very usefull, thanks